feat: Add docker bake builder #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Singh Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to bbbd6cf in 23 seconds
More details
- Looked at
629lines of code in16files - Skipped
1files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. docker-bake.hcl:72
- Draft comment:
Add a newline at the end of the file for better compatibility with various tools and systems. - Reason this comment was not posted:
Confidence changes required:20%
Thedocker-bake.hclfile is missing a newline at the end. This is a minor issue but it's a good practice to ensure files end with a newline for compatibility with various tools and systems.
2. gateway/Dockerfile:14
- Draft comment:
Consider upgrading to Traefik v3 as noted in the TODO comment for future compatibility and features. - Reason this comment was not posted:
Confidence changes required:30%
Thegateway/Dockerfilehas a TODO comment about upgrading to Traefik v3. This is not an immediate issue but should be tracked for future updates.
Workflow ID: wflow_soCgzvITGBIvWhhM
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2a82893 in 7 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/Dockerfile:16
- Draft comment:
The removal of the secondpoetry install --no-devcommand is correct as it was redundant. This change improves the Dockerfile by eliminating unnecessary steps. - Reason this comment was not posted:
Confidence changes required:0%
The removal of the secondpoetry install --no-devcommand is correct as it was redundant.
Workflow ID: wflow_4BBmLicWBzz0R8Tz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
creatorrr
added a commit
that referenced
this pull request
Sep 28, 2024
This reverts commit 5060ee3.
Vedantsahai18
pushed a commit
that referenced
this pull request
Sep 28, 2024
Introduce Docker Bake for building and pushing images with updated GitHub Actions workflows and Dockerfiles.
- **GitHub Actions Workflows**:
- Add `.github/workflows/dev-push-to-hub.yml` and `.github/workflows/main-push-to-hub.yml` for building and pushing images on `dev` and `main` branch merges.
- Remove `push-to-hub.yml` workflow.
- **Docker Build System**:
- Introduce `docker-bake.hcl` for defining Docker build targets and configurations.
- Update Dockerfiles in `agents-api`, `agents-api.worker`, `agents-api.migration` to use Docker Bake.
- **Documentation**:
- Update `CONTRIBUTING.md` with instructions for building Docker images using Docker Bake.
- **Miscellaneous**:
- Add submodules for `sdks/node-sdk` and `sdks/python-sdk`.
creatorrr
added a commit
that referenced
this pull request
Sep 30, 2024
Introduce Docker Bake for building and pushing images with updated GitHub Actions workflows and Dockerfiles.
- **GitHub Actions Workflows**:
- Add `.github/workflows/dev-push-to-hub.yml` and `.github/workflows/main-push-to-hub.yml` for building and pushing images on `dev` and `main` branch merges.
- Remove `push-to-hub.yml` workflow.
- **Docker Build System**:
- Introduce `docker-bake.hcl` for defining Docker build targets and configurations.
- Update Dockerfiles in `agents-api`, `agents-api.worker`, `agents-api.migration` to use Docker Bake.
- **Documentation**:
- Update `CONTRIBUTING.md` with instructions for building Docker images using Docker Bake.
- **Miscellaneous**:
- Add submodules for `sdks/node-sdk` and `sdks/python-sdk`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diwank Singh Tomer [email protected]
Important
Introduce Docker Bake for building and pushing images with updated GitHub Actions workflows and Dockerfiles.
.github/workflows/dev-push-to-hub.ymland.github/workflows/main-push-to-hub.ymlfor building and pushing images ondevandmainbranch merges.push-to-hub.ymlworkflow.docker-bake.hclfor defining Docker build targets and configurations.agents-api,agents-api.worker,agents-api.migrationto use Docker Bake.CONTRIBUTING.mdwith instructions for building Docker images using Docker Bake.sdks/node-sdkandsdks/python-sdk.This description was created by
for 2a82893. It will automatically update as commits are pushed.